chore(nextjs): Generalized server-side performance cleanup #3581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
AbhiPrasad
reviewed
May 21, 2021
lobsterkatie
force-pushed
the
kmclb-nextjs-parameterize-transaction-name
branch
from
40bab14 to
f960139
Compare
lobsterkatie
force-pushed
the
kmclb-nextjs-serverside-performance-cleanup
branch
from
d882819 to
1bd25dc
Compare
Base automatically changed from
kmclb-nextjs-parameterize-transaction-name
to
kmclb-next-js-performance
May 25, 2021 13:34
lobsterkatie
force-pushed
the
kmclb-nextjs-serverside-performance-cleanup
branch
from
1bd25dc to
e73c241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of random housekeeping.
instrumentServersince it's not yet defined at that point.res, since our new use of domains means thatgetActiveTransactionis safe. As a result, changeNextResponsefrom an interface to a type which is purely an alias.Serverinstance directly on the top scope rather than in an object, and get rid of the other stuff being stored in that object (closure) since it can all be gotten off of the aforementionedServerinstance.