feat: initalScope in SDK Options #3544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
May 14, 2021
AbhiPrasad
approved these changes
May 14, 2021
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Would be nice to have tests on @sentry/core and @sentry/node as well, but this LGTM.
Contributor
size-limit report
|
rhcarvalho
reviewed
May 16, 2021
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
Is this new option supposed to work for other clients too?
Please document the problem it is solving in the PR description ("the why").
Co-authored-by: Rodolfo Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the options to
Sentry.initto provide an initial Scope the SDK will be started with.We need this for our Electron SDK to have a Scope already during SDK
init(when the native crash handler starts). Potentially this is also going to be useful for dynamic sampling.