Skip to content

Conversation

@lobsterkatie
Copy link
Member

This PR makes two changes to the function which wraps the native error logger:

  • Calls the original method rather than returning a bound copy of it
  • Refactors it to be a real (non-arrow) function, so that the original this (a Server instance) isn't overwritten by the this (global) present when the function is defined

@lobsterkatie lobsterkatie requested a review from kamilogorek as a code owner May 6, 2021 20:50
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.63 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.5 KB (0%)
@sentry/react - Webpack 21.53 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.92 KB (0%)

@HazAT HazAT enabled auto-merge (squash) May 7, 2021 11:27
@HazAT HazAT disabled auto-merge May 7, 2021 11:27
@HazAT HazAT merged commit eb756d2 into master May 7, 2021
@HazAT HazAT deleted the kmclb-use-call-not-bind-in-instrument-server branch May 7, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants