Skip to content

fix(node): Disable autoSessionTracking by default #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021
Merged

fix(node): Disable autoSessionTracking by default #3511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export function init(options: NodeOptions = {}): void {
}

if (options.autoSessionTracking === undefined) {
options.autoSessionTracking = true;
options.autoSessionTracking = false;
}

if (options.environment === undefined && process.env.SENTRY_ENVIRONMENT) {
Expand Down
1 change: 1 addition & 0 deletions packages/node/test/manual/release-health/single-session/caught-exception-errored-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Sentry.init({
dsn: 'http://[email protected]/1337',
release: '1.1',
transport: DummyTransport,
autoSessionTracking: true
});

/**
Expand Down
3 changes: 2 additions & 1 deletion packages/node/test/manual/release-health/single-session/healthy-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ class DummyTransport extends BaseDummyTransport {
Sentry.init({
dsn: 'http://[email protected]/1337',
release: '1.1',
transport: DummyTransport
transport: DummyTransport,
autoSessionTracking: true
});

/**
Expand Down
3 changes: 2 additions & 1 deletion ...ages/node/test/manual/release-health/single-session/uncaught-exception-crashed-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ class DummyTransport extends BaseDummyTransport {
Sentry.init({
dsn: 'http://[email protected]/1337',
release: '1.1',
transport: DummyTransport
transport: DummyTransport,
autoSessionTracking: true
});
/**
* The following code snippet will throw an exception of `mechanism.handled` equal to `false`, and so this session
Expand Down
3 changes: 2 additions & 1 deletion ...ges/node/test/manual/release-health/single-session/unhandled-rejection-crashed-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ class DummyTransport extends BaseDummyTransport {
Sentry.init({
dsn: 'http://[email protected]/1337',
release: '1.1',
transport: DummyTransport
transport: DummyTransport,
autoSessionTracking: true
});

/**
Expand Down