Skip to content

fix: Prevent InboundFilters mergeOptions method from breaking users code #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2021
Merged

fix: Prevent InboundFilters mergeOptions method from breaking users code #3458

merged 2 commits into from
Apr 26, 2021

Conversation

@kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Apr 26, 2021

See code comment for an explanation.

Fixes #2622

@kamilogorek kamilogorek requested review from a team, ahmedetefy and lobsterkatie and removed request for a team April 26, 2021 10:02
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.63 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.5 KB (0%)
@sentry/react - Webpack 21.53 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.92 KB (0%)

rhcarvalho
rhcarvalho approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

@kamilogorek @rhcarvalho
Apply suggestions from code review
64c758f 
Co-authored-by: Rodolfo Carvalho <[email protected]>
@kamilogorek kamilogorek merged commit 76cc560 into master Apr 26, 2021
@kamilogorek kamilogorek deleted the inboundfilters-mergeoptions branch April 26, 2021 11:39
@lforst lforst mentioned this pull request Apr 20, 2022
Closed
@lforst lforst mentioned this pull request Jun 30, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmedetefy ahmedetefy Awaiting requested review from ahmedetefy

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

1 more reviewer

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Internal Sentry Error: r._mergeOptions is not a function

3 participants

@kamilogorek @rhcarvalho