feat(node): Implement category based rate limiting #3435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedetefy
force-pushed
the
ahmed-ratelimit-node
branch
from
12b0628 to
2af71f0
Compare
Contributor
size-limit report
|
kamilogorek
approved these changes
Apr 22, 2021
Contributor
kamilogorek
left a comment
kamilogorek
left a comment
There was a problem hiding this comment.
Perfect copy-paste skills 🥰
HazAT
requested changes
May 4, 2021
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
I think the only thing missing is bogus test cases where the header is malformed or not there.
Also what about an unknown category?
ahmedetefy
force-pushed
the
ahmed-ratelimit-node
branch
from
2af71f0 to
fa33eb1
Compare
ahmedetefy
force-pushed
the
ahmed-ratelimit-node
branch
from
fa33eb1 to
7e3e604
Compare
HazAT
requested changes
May 6, 2021
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
Do we really need to test both http and https and have a lot of duplicated tests? I think for this PR that's not necessary.
Add Category rate limiting based on SentryRequestType
ahmedetefy
force-pushed
the
ahmed-ratelimit-node
branch
from
7e3e604 to
c9978cd
Compare
rhcarvalho
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
event,transaction,sessionX-Sentry-Rate-Limitsheader -> all categories are rate limited