-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(node): Generate a Sentry Release string from env if its not provided #3393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a33d60d to
4b0cafc
Compare
…elease is not provided on init
8500da4 to
204eae7
Compare
size-limit report
|
|
tbh I'd prefer to have it |
Oh so you mean only if autoSessionTracking is enabled? |
|
More like: if (options.release === undefined) {
const detectedRelease = getSentryRelease();
if (detectedRelease !== undefined) {
options.release = detectedRelease;
}
}Otherwise we'll always end up with |
…nt, then release should be undefined
Done! |
…al sentry release is set
This PR: