-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Rework how we track sessions #3224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report
|
lobsterkatie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some naming questions (you know me!). Also, do we have any tests covering this?
Otherwise, looks good. 🙂
Co-authored-by: Katie Byers <[email protected]>
|
I will prepare a beta release from this branch so we can test it on sentry.io |
This reverts commit f25938f.
lobsterkatie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
|
sentry.io PR |
How we track session now:
init: trueandstatus: ok-> After sending the session switches toinit: falsein the scopeerror: +1and send the updateerror: +1, setstatus: crashedand send the update-- If the Session was
status: crashedit staysstatus: crashed-- If the Session was
status: okit will be changed tostatus: exited