Skip to content

ref: Make ExpressRequest not extend http.IncomingMessage anymore #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2021
Merged

ref: Make ExpressRequest not extend http.IncomingMessage anymore #3211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/node/src/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@ import { flush } from './sdk';

const DEFAULT_SHUTDOWN_TIMEOUT = 2000;

export interface ExpressRequest extends http.IncomingMessage {
[key: string]: any;
export interface ExpressRequest {
baseUrl?: string;
connection?: {
remoteAddress?: string;
};
ip?: string;
method?: string;
originalUrl?: string;
route?: {
path: string;
Expand All @@ -33,6 +36,11 @@ export interface ExpressRequest extends http.IncomingMessage {
},
];
};
query?: {
// It can be: undefined | string | string[] | ParsedQs | ParsedQs[] (from `qs` package), but we dont want to pull it.
[key: string]: unknown;
};
url?: string;
user?: {
[key: string]: any;
};
Expand Down