feat: Allow for attaching metadata and pass it to the API and transports #3177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
|
For posteriority, this is related to #3170, as it would simplify the implementation of that one. |
rhcarvalho
reviewed
Jan 15, 2021
Indeed. @kamilogorek, even though this replaces that one, you might consider grabbing its tests (which you'd only have to modify a little) since they're already written. (I missed gatsby entirely in that PR, but fortunately the test there already exists and only needs to be updated.) |
HazAT
requested changes
Jan 18, 2021
| const sdkInfo = getSdkInfoFromApiMetadata(api); | ||
| const envelopeHeaders = JSON.stringify({ | ||
| sent_at: new Date().toISOString(), | ||
| ...(sdkInfo && { sdk: sdkInfo }), |
There was a problem hiding this comment.
We only want name and version here not everything.
| const envelopeHeaders = JSON.stringify({ | ||
| event_id: event.event_id, | ||
| sent_at: new Date().toISOString(), | ||
| ...(sdkInfo && { sdk: sdkInfo }), |
There was a problem hiding this comment.
Same here: We only want name and version here, not everything.
HazAT
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need some tinkering and tests.
options._metadatawhich is type ofSdkMetadata = { sdk?: SdkInfo }options.transportOptionsinternally and passed to the transportnew APIwhich now has the ability to read this data-SDK_VERSIONis fixed and always read from@sentry/coreSDK_VERSIONis moved to@sentry/coreSDK_NAMEis kept where it was for backwards compatibilityand@sentry/browserand@sentry/nodestill use it as before, so it can be used as fallback for "unknown" SDKs or in a fail-safe scenario- event processors are still in place, as we use them to enhancepackagesattribute, as well as we have to modify the event itself, which is not using envelopes yet