ci(release): Run Craft on the host, not in Docker #3130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3128. #skip-changelog
BYK
commented
Dec 17, 2020
jan-auer
reviewed
Dec 17, 2020
Contributor
size-limit report
|
Co-authored-by: Jan Michael Auer <[email protected]>
jan-auer
approved these changes
Dec 17, 2020
Member
|
Merging without codeowner approval on behalf of |
BYK
added a commit
to getsentry/action-prepare-release
that referenced
this pull request
Dec 22, 2020
This PR bundles the 'Craft Prepare' and 'Request publish' steps by leveraging the fact that Craft can be run outside of the Docker image, w/o the Craft action as done in getsentry/sentry-javascript#3130. It also improves the automatically crated publish request issue's body by adding the comparison link, normally produced by Craft and tagging the initiator/requester of the release. This PR **SHOULD NOT** be merged before pinning all dependents of `action-prepare-release` as it is very likely to break them. This action now requirest `action/checkout` to be run beforehand.
BYK
added a commit
to getsentry/action-prepare-release
that referenced
this pull request
Dec 22, 2020
This PR bundles the 'Craft Prepare' and 'Request publish' steps by leveraging the fact that Craft can be run outside of the Docker image, w/o the Craft action as done in getsentry/sentry-javascript#3130. It also improves the automatically crated publish request issue's body by adding the comparison link, normally produced by Craft and tagging the initiator/requester of the release. This PR **SHOULD NOT** be merged before pinning all dependents of `action-prepare-release` as it is very likely to break them. This action now requirest `action/checkout` to be run beforehand.
BYK
added a commit
to getsentry/action-prepare-release
that referenced
this pull request
Jan 6, 2021
This PR bundles the 'Craft Prepare' and 'Request publish' steps by leveraging the fact that Craft can be run outside of the Docker image, w/o the Craft action as done in getsentry/sentry-javascript#3130. It also improves the automatically crated publish request issue's body by adding the comparison link, normally produced by Craft and tagging the initiator/requester of the release. This action now requires `action/checkout` to be run beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3128.
#skip-changelog