fix(express): Make tests match new route name extraction behavior #3103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-fix-parserequest-tests
branch
from
922adbb to
f223456
Compare
HazAT
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change made it so we always prefer the parameterized path if it's available. This fixes the tests to match that expectation.
It also renames
extractRouteInfotoextractExpressTransactionName, to better reflect its return values and usage, and adds a bunch of typecasts to the tests so TS can stop stressing. (Our mock request is missing many ofhttp.IncomingMessage's less interesting properties. We're not testing them, though, so we don't care.)