fix(tracing): Add sentry-trace header to outgoing http(s) requests in node
#3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-node-http-sentry-trace-header
branch
from
103e760 to
1eaa6af
Compare
lobsterkatie
changed the title
sentry-trace header to outgoing http(s) requests in nodesentry-trace header to outgoing http(s) requests in node
Contributor
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-node-http-sentry-trace-header
branch
10 times, most recently
from
80e172b to
ec39c29
Compare
kamilogorek
reviewed
Nov 24, 2020
kamilogorek
reviewed
Nov 24, 2020
kamilogorek
reviewed
Nov 24, 2020
kamilogorek
reviewed
Nov 24, 2020
lobsterkatie
force-pushed
the
kmclb-node-http-sentry-trace-header
branch
from
ec39c29 to
6d34c9f
Compare
lobsterkatie
force-pushed
the
kmclb-node-http-sentry-trace-header
branch
from
6d34c9f to
4d76edd
Compare
lobsterkatie
force-pushed
the
kmclb-node-http-sentry-trace-header
branch
from
4d76edd to
dcee804
Compare
kamilogorek
reviewed
Dec 2, 2020
| /** | ||
| * Normalize inputs to `http(s).request()` and `http(s).get()`. | ||
| * | ||
| * Legal inputs to `http(s).request()` and `http(s).get()` can take one of ten forms: |
kamilogorek
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings
@sentry/nodein line with@sentry/browser, in that any outgoing request recorded as a span will now correctly include thesentry-traceheader.Main Changes:
Split
integrations/httputils off into their own file (things were getting unwieldy).urlToOptionsandnormalizeRequestArgsare the only actual additions there.Handle all allowable inputs to
http(s).request()andhttp(s).get(we were missing the option of passing aURLobject) by normalizing those inputs to one of two options, down from ten.Fix the types in various places where we had them backwards (requests typed as responses and vice-versa).
Move our node types to version 10 as a) until two days ago, that version included
methodin thehttp.ClientRequesttype whereas version 11 didn't for some reason, and b) even now that that's moot, if we supposedly support node versions back to 6, we shouldn't be using types which didn't exist back then.v10is the earliest node version supported by@types/node, and is still being actively maintained, so it seemed like a good compromise.(The whole point) Add
sentry-traceheader to outgoing requests.