Skip to content

fix: Remove globalThis usage #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix: Remove globalThis usage #3033

merged 1 commit into from
Nov 5, 2020

Conversation

@kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Nov 5, 2020

Fixes #2978

@kamilogorek kamilogorek requested a review from HazAT November 5, 2020 14:44
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.72 KB (0%)
@sentry/browser - Webpack 20.58 KB (0%)
@sentry/react - Webpack 20.58 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.86 KB (0%)

@kamilogorek kamilogorek merged commit cadc3f3 into master Nov 5, 2020
@kamilogorek kamilogorek deleted the remove-globalthis branch November 5, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ERROR in node_modules/@sentry/browser/dist/transports/base.d.ts(31,19): error TS2503: Cannot find namespace 'globalThis'.

3 participants

@kamilogorek @HazAT