Skip to content

fix(transitions): prevent unexpected errors on ember transition #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix(transitions): prevent unexpected errors on ember transition #2988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember/addon/instance-initializers/sentry-performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function initialize(appInstance: ApplicationInstance): void {

function getTransitionInformation(transition: any, router: any) {
const fromRoute = transition?.from?.name;
const toRoute = transition ? transition.to.name : router.currentRouteName;
const toRoute = transition && transition.to ? transition.to.name : router.currentRouteName;
Copy link
Contributor Author

@arnaudbesnier arnaudbesnier Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how it can happen but, in my EmberJS project using ember-simple-auth after a login the transition object from the login page to the default authenticated page contains no to key.
route.currentRouteName is well defined.

This defensive programming contribution fixes my issue.

return {
fromRoute,
toRoute,
Expand Down