Pass scope data for transactions in serverless #2975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall-lee
force-pushed
the
serverless/fix-transactions-scope
branch
from
a36385b to
9ed478f
Compare
Contributor
Author
|
I ported your approach with |
marshall-lee
force-pushed
the
serverless/fix-transactions-scope
branch
from
9ed478f to
cbe5cd6
Compare
Contributor
Author
|
@kamilogorek ping |
HazAT
approved these changes
Oct 19, 2020
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2945 I added transaction support in a way that it doesn't capture any context info for transaction events :(
Though it captures exception events context just fine, it misses the context for transaction events. This PR aims to fix it.