docs(ember): Mention tracesSampleRate in Ember docs
#2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
changed the title
tracesSampleRate in Ember docstracesSampleRate in Ember docs
This should help new users get started faster by including what is needed for performance right away.
k-fish
approved these changes
Sep 25, 2020
Member
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
Awesome, thanks for that. I had a commit I didn't push that added it right to the config, since performance is enabled by default, it should be easier for people to get started with it always on and they can lower it for their production environment after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a paragraph mentioning setting
tracesSampleRatein the@sentry/emberreadme.I just spent way to much time trying to figure out why no performance data is sent, until I noticed that I have to manually set this property in my config :)