- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.7k
build: Convert utils, apm, angular, gatsby, ember to eslint #2804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | size-limit report
 | 
b505e70    to
    cf4b5e6      
    Compare
  
    | I went throught config files and they look good. As for the code part, if it lints, it lints ¯_(ツ)_/¯ | 
              
                    kamilogorek
  
              
              approved these changes
              
                  
                    Aug 11, 2020 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
@sentry/utilsto using eslint@sentry/apmto using eslint@sentry/angularto using eslint@sentry/gatsbyto using eslint@sentry/emberto using eslint (Basically already was using eslint)Also updated so that lint would update cache - that should further reduce lint times (we can also store cache in github actions -> reduce CI time even more). It stores all the cache files in a top level folder called
eslintcache.Added some new rules:
What is left: