build: Convert core, hub, minimal and types to use eslint #2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
HazAT
approved these changes
Aug 5, 2020
kamilogorek
pushed a commit
that referenced
this pull request
Aug 10, 2020
* build: Switch `@sentry/core` to using eslint * build: Switch `@sentry/hub` to using eslint * build: Switch `@sentry/minimal` to using eslint * build: Switch `@sentry/types` to using eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #2786, keep converting stuff to eslint.
This takes care of
@sentry/core,@sentry/hub,@sentry/minimaland@sentry/types.Same logic as the first done for
@sentry/browser,.eslintrc.jsand extend from main configGoal is to do one of these a day, so we finish by Friday 😄