fix: Mark side effects for tracing hub extensions #2788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi/side-effects
branch
from
7dffc0b to
e1fe166
Compare
Contributor
size-limit report
|
Contributor
dashed
approved these changes
Jul 31, 2020
HazAT
approved these changes
Aug 3, 2020
kamilogorek
pushed a commit
that referenced
this pull request
Aug 10, 2020
* fix: Mark side effects for tracing hub extensions * fix: Add side effect for React package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tells webpack or other bundlers that the index file has side effects.