Skip to content

fix: Extract transaction from nested express paths correctly #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2020
Merged

fix: Extract transaction from nested express paths correctly #2714

merged 2 commits into from
Jul 1, 2020

Conversation

@kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jul 1, 2020

Fixes #2708

@kamilogorek kamilogorek requested a review from HazAT July 1, 2020 14:18
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jul 1, 2020

Fails
🚫

TSLint failed: @sentry/node

  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/node/src/handlers.ts[98, 7]: Use a conditional expression instead of assigning to 'routePath' in multiple places.
  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/node/test/handlers.test.ts[18, 7]: The key 'originalUrl' is not sorted alphabetically
Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.1387 kB) (ES6: 16.252 kB)

Generated by 🚫 dangerJS against 0c92795

@kamilogorek kamilogorek merged commit 5325fe3 into master Jul 1, 2020
@kamilogorek kamilogorek deleted the express-transaction-path branch July 1, 2020 14:35
@apmorton apmorton mentioned this pull request Oct 11, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generated transaction name is wrong with express nested routers

4 participants

@kamilogorek @getsentry-bot @HazAT