Skip to content

Conversation

@xiaoxiaojx
Copy link
Contributor

Delete useless condition judgment

@xiaoxiaojx xiaoxiaojx requested a review from kamilogorek as a code owner June 16, 2020 09:28
@xiaoxiaojx
Copy link
Contributor Author

xiaoxiaojx commented Jun 16, 2020

private readonly _iteratee: StackFrameIteratee = (frame: StackFrame) => {
    // here ~
    if (!frame.filename) {
      return frame;
    }
    // Check if the frame filename begins with `/` or a Windows-style prefix such as `C:\`
    const isWindowsFrame = /^[A-Z]:\\/.test(frame.filename);
    const startsWithSlash = /^\//.test(frame.filename);
    if (frame.filename && (isWindowsFrame || startsWithSlash)) {

@kamilogorek kamilogorek merged commit 236f8d7 into getsentry:master Jun 16, 2020
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants