Skip to content

Conversation

@lobsterkatie
Copy link
Member

Adds tests to #2429.

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Feb 14, 2020

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES6: 15.7412 kB) (ES5: 16.7314 kB)

Generated by 🚫 dangerJS against 4e7ab65

@lobsterkatie lobsterkatie changed the title fix(integrations): Add tests for CustomEvent handling fix WIP: fix(integrations): Add tests for CustomEvent handling fix Feb 14, 2020
@lobsterkatie lobsterkatie changed the title WIP: fix(integrations): Add tests for CustomEvent handling fix fix(integrations): Add tests for CustomEvent handling fix Feb 14, 2020
summary.events[0].exception.values[0].mechanism.type,
"onunhandledrejection"
);
// even though it's a regular Event (rather than a PRE) it should sill only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// even though it's a regular Event (rather than a PRE) it should sill only
// even though it's a regular Event (rather than a PRE) it should still only

Co-Authored-By: Kamil Ogórek <[email protected]>
@kamilogorek kamilogorek self-requested a review February 17, 2020 09:32
@kamilogorek kamilogorek merged commit 644b36c into master Feb 19, 2020
@kamilogorek kamilogorek deleted the kmclb-fake-promise-rejection-handling-tests branch February 19, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants