Updated documentation with some clarification of the optional settings #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is fair. The reason is because the url matching and stuff depend on fields that come from the Error object itself. They just don't apply to plain messages. :) |
mattrobenolt
added a commit
that referenced
this pull request
Aug 11, 2014
Updated documentation with some clarification of the optional settings
billyvg
added a commit
that referenced
this pull request
Feb 26, 2025
- fix(snapshot): Do not attempt to load iframe at all if it is blocked (#240) See https://github.com/getsentry/rrweb/releases/tag/2.33.0
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some additions to the docs in order to clarify that some of the optional settings only apply to the captureException call, and not the captureMessage.
Example of one more person than me that got confused by this: #196
If this is the expected behaviour is another discussion, but I think it is good if the docs make it clear how it currently works.