Set request headers to ones provided in transportOpts in XHR transport #2363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
requested changes
Dec 18, 2019
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
Seems like a reasonable addition 👍
Can you please fix the lint errors on CI?
kamilogorek
reviewed
Dec 18, 2019
Contributor
Author
Will do. Probably should have run |
Sija
reviewed
Dec 18, 2019
Co-Authored-By: Sijawusz Pur Rahnama <[email protected]>
HazAT
requested changes
Dec 19, 2019
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
One thing I noticed, can you please also add this to the FetchTransport to make it feature complete? We use fetch by default if the browser supports it and I assume it will also be helpful there.
Contributor
Author
No problem. |
This was referenced Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our instance of Sentry is behind a proxy that requires an OAuth bearer token to be passed in the Authorization header. The default XHR transport does not offer a way of easily setting any headers. In my own project, I copied the XHR transport and added a line to set requests. I thought it might be nice to have in the default XHR transport as well.