Skip to content

Conversation

@kamilogorek
Copy link
Contributor

Fixes #1600
Fixes #2336

"Because browsers..."

https://html.spec.whatwg.org/multipage/webappapis.html#the-event-handler-processing-algorithm

If special error event handling is true
If return value is true, then set event's canceled flag.

Otherwise
If return value is false, then set event's canceled flag.

but

There are two exceptions in the platform, for historical reasons:
The onerror handlers on global objects, where returning true cancels the event

@kamilogorek kamilogorek requested a review from HazAT December 6, 2019 14:25
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.5498 kB) (ES6: 15.5547 kB)

Generated by 🚫 dangerJS against 983ffc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No console errors shown if unhandled error occured How to log exceptions (captureException) to console too

4 participants