fix: Make sure that XHR is wrapped correctly for TryCatch and Instrument #2343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HazAT
approved these changes
Dec 5, 2019
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
Tested it with socket.io example and it works
|
thanks for update |
Member
|
@vadimka123 Now :) |
|
you mean new version on npm? |
Contributor
Author
|
@vadimka123 release is in progress as we speak, should be live in ~10-15min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2340
Fixes #2337