Skip to content

Conversation

@ouraios
Copy link
Contributor

@ouraios ouraios commented Dec 4, 2019

https-proxy-agent patches core Node methods in https for whatever reason, and that breaks unrelated code. In our app we don't use proxy, and the mere fact that sentry-javascript requires the proxy package, it breaks other code.

See TooTallNate/node-agent-base#35 and sindresorhus/got#951

@ouraios ouraios requested a review from kamilogorek as a code owner December 4, 2019 13:57
@HazAT
Copy link
Member

HazAT commented Dec 5, 2019

Thanks for the PR!
Can you please run yarn lint locally, there are a few linting errors that our CI is not posting here.

@ouraios
Copy link
Contributor Author

ouraios commented Dec 5, 2019

@HazAT I have linting error on @sentry/utils but i haven't edited any filed in @sentry/utils only in @sentry/node :/

@kamilogorek
Copy link
Contributor

@ouraios you need to run yarn build in the root directory in order for TypeScript to pick up files from monorepo correctly

@ouraios
Copy link
Contributor Author

ouraios commented Dec 5, 2019

@kamilogorek Thanks for letting me know, im not used to lerna
But i did the yarn build and i ran yarn lint in both root directory and node package and it's telling me everything is okay :x

@kamilogorek
Copy link
Contributor

Merged by hand 18fbd73
Thanks!

@kamilogorek kamilogorek closed this Dec 5, 2019
@ouraios
Copy link
Contributor Author

ouraios commented Dec 5, 2019

Thanks a lot for your reactivity !

@kamilogorek
Copy link
Contributor

@ouraios and already released as 5.10.1 if you want to try it out :)

@ouraios
Copy link
Contributor Author

ouraios commented Dec 5, 2019

@kamilogorek Its not released on npm already :(

@HazAT
Copy link
Member

HazAT commented Dec 5, 2019

@jstewmon
Copy link

Sorry for commenting on a closed issue. I wanted to leave this on #2085, but GH is having trouble serving that issue page...

agent-base 5.0.0 is out and no longer patches https.request: https://github.com/TooTallNate/node-agent-base/releases/tag/5.0.0

@ouraios
Copy link
Contributor Author

ouraios commented Dec 11, 2019

Great thanks ! it works like a charm !

@kamilogorek
Copy link
Contributor

Awesome! Thanks for a headsup @jstewmon. I'll definitely update that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants