Skip to content

Conversation

@chrisblossom
Copy link
Contributor

Currently NodeOptions are not typed because [key: string]: any matches any key.

FYI, I was unable to get lerna (yes I am familiar how it works and followed Contributing as well) to properly install so I am unable to check if typescript still passes.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@chrisblossom chrisblossom requested a review from kamilogorek as a code owner June 6, 2019 20:00
@kamilogorek kamilogorek merged commit 1127cf4 into getsentry:master Jul 5, 2019
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants