-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(cloudflare): Add honoIntegration
with error-filtering function
#17743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
s1gr1d
commented
Sep 23, 2025
import baseConfig from '../../vite/vite.config'; | ||
|
||
export default defineConfig({ | ||
...baseConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to add a vite.config.ts file because the baseConfig
defines this:
define: {
__DEBUG_BUILD__: true,
},
...and this was needed to make the unit tests work.
mydea
reviewed
Sep 24, 2025
mydea
reviewed
Sep 24, 2025
mydea
reviewed
Sep 24, 2025
cf3207d
to
e910c66
Compare
mydea
approved these changes
Sep 24, 2025
3 tasks
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
honoIntegration
that exposes ashouldHandleError
function that lets users define a custom handling of capturing errors. By default, we capture exceptions witherror.status >= 500 || error.status <= 299
.It's possible to modify this behavior like this:
Up for discussion: The function name is the same like in express/fastify to keep it consistent. But I was also thinking about other names like
shouldHandleInOnError
orshouldCaptureOnError
🤔 Because it's specifically about theonError
function. Let me know what you think.closes #17717