ref(browser): Improve fetchTransport error handling
#17661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Sep 16, 2025
| ...options.fetchOptions, | ||
| }; | ||
|
|
||
| if (!nativeFetch) { |
There was a problem hiding this comment.
this lead to pendingXX not being cleaned up in this case.
mydea
commented
Sep 16, 2025
| */ | ||
| export function makeFetchTransport( | ||
| options: BrowserTransportOptions, | ||
| nativeFetch: typeof WINDOW.fetch | undefined = getNativeImplementation('fetch'), |
There was a problem hiding this comment.
this type was not what we expected it to be, as nativeFetch was interpreted to be typeof fetch anyhow because the undefined just lead to it assuming the return type of getNativeImplementation('fetch'), which was also typeof fetch 😅
size-limit report 📦
|
Lms24
reviewed
Sep 16, 2025
| ...options.fetchOptions, | ||
| }; | ||
|
|
||
| if (!nativeFetch) { |
Lms24
approved these changes
Sep 16, 2025
mydea
force-pushed
the
fn/transport-adjustments
branch
from
3996942 to
dd26af9
Compare
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our fetch transport a bit, making use of async functions and slightly adjusting error handling:
pendingBodySize/pendingCountand never decrease it.Extracted this out of #17641