feat(core,node): Add instrumentation for GoogleGenAI
#17625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
RulaKhaled
force-pushed
the
instrument-genai-google
branch
from
52f49f5 to
6ef5ce0
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
packages/node/src/integrations/tracing/google-genai/instrumentation.ts
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
RulaKhaled
force-pushed
the
instrument-genai-google
branch
from
af4e147 to
2a58c6a
Compare
mydea
reviewed
Sep 16, 2025
dev-packages/node-integration-tests/suites/tracing/google-genai/scenario.mjs
Outdated
Show resolved
Hide resolved
mydea
reviewed
Sep 16, 2025
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
packages/node/src/integrations/tracing/google-genai/instrumentation.ts
Outdated
Show resolved
Hide resolved
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
packages/node/src/integrations/tracing/google-genai/instrumentation.ts
Outdated
Show resolved
Hide resolved
mydea
reviewed
Sep 17, 2025
RulaKhaled
force-pushed
the
instrument-genai-google
branch
from
224c1a3 to
60eb2d1
Compare
RulaKhaled
force-pushed
the
instrument-genai-google
branch
from
60eb2d1 to
275a9a7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mydea
reviewed
Sep 19, 2025
| tracesSampleRate: 1.0, | ||
| sendDefaultPii: true, | ||
| transport: loggingTransport, | ||
| integrations: [Sentry.googleGenAIIntegration()], |
There was a problem hiding this comment.
Suggested change
| integrations: [Sentry.googleGenAIIntegration()], |
this is added by default, right? So no need to add this here :)
mydea
reviewed
Sep 19, 2025
| tracesSampleRate: 1.0, | ||
| sendDefaultPii: false, | ||
| transport: loggingTransport, | ||
| integrations: [Sentry.googleGenAIIntegration()], |
There was a problem hiding this comment.
Suggested change
| integrations: [Sentry.googleGenAIIntegration()], |
mydea
reviewed
Sep 19, 2025
| /** | ||
| * Google GenAI Integration interface for type safety | ||
| */ | ||
| export interface GoogleGenAIIntegration { |
There was a problem hiding this comment.
do we actually need this, when we do not lookup the integration on the client anymore? :)
mydea
reviewed
Sep 19, 2025
| * @param wrappedConstructor The wrapped constructor function to replace the original with | ||
| * @returns void | ||
| */ | ||
| export function replaceExports( |
mydea
reviewed
Sep 19, 2025
| exports => this._patch(exports), | ||
| exports => exports, | ||
| [ | ||
| new InstrumentationNodeModuleFile( |
There was a problem hiding this comment.
let's add a comment here why this is necessary, for future reference!
mydea
reviewed
Sep 19, 2025
| const config = this.getConfig(); | ||
|
|
||
| if (typeof Original !== 'function') { | ||
| return; |
There was a problem hiding this comment.
Suggested change
| return; | |
| return exports; |
Do we not need to return the exports here if we do not patch it? 🤔 or is this handled if this is undefined and we do nothing then? just double checking 😅
There was a problem hiding this comment.
Nah i think you're correct
mydea
approved these changes
Sep 19, 2025
This was referenced Sep 23, 2025
RulaKhaled
changed the title
GoogleGenerativeAIGoogleGenAI
This was referenced Sep 29, 2025
RulaKhaled
added a commit
that referenced
this pull request
Oct 1, 2025
…17664) ✅ This PR depends on #17625 and it should be reviewed only after that one is merged. This PR adds: 1. Streaming support for Google GenAI sdk instrumenting the following methods: 1. Models API Streaming - `models.generateContentStream()` - Stream content generation with real-time chunks 3. Chat API Streaming (chats.create) - `chat.sendMessageStream()` - Stream chat responses with conversation context 2. New tool calls attributes - GEN_AI_REQUEST_AVAILABLE_TOOLS_ATTRIBUTE - Captures available tools from requests - GEN_AI_RESPONSE_TOOL_CALLS_ATTRIBUTE - Captures function calls from responses --------- Co-authored-by: Andrei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements instrumentation for the Google Gen AI SDK, adding automatic tracing for both direct model calls (models.generateContent) and conversational chat sessions (chats.create + sendMessage). The implementation follows Sentry's AI Agents Manual Instrumentation conventions and includes integration tests.
Usage: