Skip to content

ref(node-core): Add mechanism to cron instrumentations #17544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

ref(node-core): Add mechanism to cron instrumentations #17544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f89b0f
ref(node-core): Add `mechanism` to cron instrumentations
Lms24 Jul 31, 2025
0c60aa2
adjust tests
Lms24 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dev-packages/node-core-integration-tests/suites/cron/cron/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,15 @@ test('cron instrumentation', async () => {
})
.expect({
event: {
exception: { values: [{ type: 'Error', value: 'Error in cron job' }] },
exception: {
values: [
{
type: 'Error',
value: 'Error in cron job',
mechanism: { type: 'auto.function.cron.instrumentCron', handled: false },
},
],
},
},
})
.start()
Expand Down
10 changes: 9 additions & 1 deletion dev-packages/node-core-integration-tests/suites/cron/node-cron/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,15 @@ test('node-cron instrumentation', async () => {
})
.expect({
event: {
exception: { values: [{ type: 'Error', value: 'Error in cron job' }] },
exception: {
values: [
{
type: 'Error',
value: 'Error in cron job',
mechanism: { type: 'auto.function.node-cron.instrumentNodeCron', handled: false },
},
],
},
},
})
.start()
Expand Down
10 changes: 9 additions & 1 deletion dev-packages/node-core-integration-tests/suites/cron/node-schedule/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,15 @@ test('node-schedule instrumentation', async () => {
})
.expect({
event: {
exception: { values: [{ type: 'Error', value: 'Error in cron job' }] },
exception: {
values: [
{
type: 'Error',
value: 'Error in cron job',
mechanism: { type: 'onunhandledrejection', handled: false },
},
],
},
},
})
.start()
Expand Down
14 changes: 12 additions & 2 deletions packages/node-core/src/cron/cron.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ export function instrumentCron<T>(lib: T & CronJobConstructor, monitorSlug: stri
try {
await onTick(context, onComplete);
} catch (e) {
captureException(e);
captureException(e, {
mechanism: {
handled: false,
type: 'auto.function.cron.instrumentCron',
},
});
throw e;
}
},
Expand Down Expand Up @@ -136,7 +141,12 @@ export function instrumentCron<T>(lib: T & CronJobConstructor, monitorSlug: stri
try {
await onTick(context, onComplete);
} catch (e) {
captureException(e);
captureException(e, {
mechanism: {
handled: false,
type: 'auto.function.cron.instrumentCron',
},
});
throw e;
}
},
Expand Down
7 changes: 6 additions & 1 deletion packages/node-core/src/cron/node-cron.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,12 @@ export function instrumentNodeCron<T>(lib: Partial<NodeCron> & T): T {
try {
return await callback();
} catch (e) {
captureException(e);
captureException(e, {
mechanism: {
handled: false,
type: 'auto.function.node-cron.instrumentNodeCron',
},
});
throw e;
}
},
Expand Down