Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 5, 2025

Cursor's bugbot PR review feature accepts custom rules. Let's use this to enhance Cursor's reviewing capabilities with SDK-specific conventions. This PR adds a couple of them, paired with some more general important concerns.

As a general rule of thumb: Let's add things that are hard to lint against but should still be flagged (like span origin or exception mechanisms). If this causes cursor to spam us with crap, we can always make things more or less specific of course. But I think this is worth a try.

@Lms24 Lms24 self-assigned this Aug 5, 2025
@Lms24 Lms24 requested review from mydea and s1gr1d August 5, 2025 14:45
@Lms24 Lms24 merged commit 6d451e9 into develop Aug 5, 2025
34 checks passed
@Lms24 Lms24 deleted the lms/chore-cursor-review-rules branch August 5, 2025 14:52
RulaKhaled pushed a commit that referenced this pull request Aug 7, 2025
Cursor's bugbot PR review feature accepts [custom
rules](https://docs.cursor.com/en/bugbot#rules). Let's use this to
enhance Cursor's reviewing capabilities with SDK-specific conventions.
This PR adds a couple of them, paired with some more general important
concerns.

As a general rule of thumb: Let's add things that are hard to lint
against but should still be flagged (like span origin or exception
mechanisms). If this causes cursor to spam us with crap, we can always
make things more or less specific of course. But I think this is worth a
try.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants