Skip to content

fix(node): Assign default export of openai to the instrumented fn #17320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
+17 −0
Merged

fix(node): Assign default export of openai to the instrumented fn #17320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356875c
fix(node): Assign default export of openai to the instrumented fn
RulaKhaled Aug 5, 2025
904e26b
add a comment
RulaKhaled Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/node/src/integrations/tracing/openai/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,23 @@ export class SentryOpenAiInstrumentation extends InstrumentationBase<Instrumenta
enumerable: true,
});
}

// Wrap the default export if it points to the original constructor
// Constructor replacement - handle read-only properties
// The OpenAI property might have only a getter, so use defineProperty
if (exports.default === Original) {
try {
exports.default = WrappedOpenAI;
} catch (error) {
// If direct assignment fails, override the property descriptor
Object.defineProperty(exports, 'default', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a comment here explaining what we do here and why? When would this fail, and would the catch block work then? Can/should we just always do the catch block here?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on it

value: WrappedOpenAI,
writable: true,
configurable: true,
enumerable: true,
});
}
}
return exports;
}
}
Loading