Skip to content

build: Disable side-effects for any ./debug-build.ts file #16929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025
Merged

build: Disable side-effects for any ./debug-build.ts file #16929

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9739305
build: Disable side-effects for any `./debug-build.ts` file
timfish Jul 11, 2025
75f8a85
no array
timfish Jul 11, 2025
8f867b7
Merge branch 'develop' into timfish/build/exclude-debug-build-side-ef…
timfish Jul 11, 2025
a4c5611
clearer logic
timfish Jul 11, 2025
11c63cb
Merge branch 'timfish/build/exclude-debug-build-side-effects' of gith…
timfish Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions dev-packages/rollup-utils/npmHelpers.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url));

const packageDotJSON = JSON.parse(fs.readFileSync(path.resolve(process.cwd(), './package.json'), { encoding: 'utf8' }));

const ignoreSideEffects = /[\\\/]debug-build\.ts$/;

export function makeBaseNPMConfig(options = {}) {
const {
entrypoints = ['src/index.ts'],
Expand Down Expand Up @@ -83,6 +85,17 @@ export function makeBaseNPMConfig(options = {}) {
interop: 'esModule',
},

treeshake: {
moduleSideEffects: (id, external) => {
if (external === false && ignoreSideEffects.test(id)) {
// Tell Rollup this module has no side effects, so it can be tree-shaken
return false;
}

return true;
}
},

plugins: [nodeResolvePlugin, sucrasePlugin, debugBuildStatementReplacePlugin, rrwebBuildPlugin, cleanupPlugin],

// don't include imported modules from outside the package in the final output
Expand Down
Loading