meta(changelog): Update changelog for 9.37.0

.github/dependabot.yml

@@ -16,7 +16,7 @@ updates:
       - dependency-name: '@sentry/*'
       - dependency-name: '@opentelemetry/*'
       - dependency-name: '@prisma/instrumentation'
-      - dependency-name: 'opentelemetry-instrumentation-remix'
+      - dependency-name: '@playwright/test'
     versioning-strategy: increase
     commit-message:
       prefix: feat

CHANGELOG.md

@@ -4,6 +4,30 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 9.37.0
+
+### Important Changes
+
+- **feat(nuxt): Parametrize SSR routes ([#16843](https://github.com/getsentry/sentry-javascript/pull/16843))**
+
+  When requesting dynamic or catch-all routes in Nuxt, those will now be shown as parameterized routes in Sentry.
+  For example, `/users/123` will be shown as `/users/:userId()` in Sentry. This will make it easier to identify patterns and make grouping easier.
+
+### Other Changes
+
+- feat(astro): Deprecate passing runtime config to astro integration ([#16839](https://github.com/getsentry/sentry-javascript/pull/16839))
+- feat(browser): Add `beforeStartNavigationSpan` lifecycle hook ([#16863](https://github.com/getsentry/sentry-javascript/pull/16863))
+- feat(browser): Detect redirects when emitting navigation spans ([#16324](https://github.com/getsentry/sentry-javascript/pull/16324))
+- feat(cloudflare): Add option to opt out of capturing errors in `wrapRequestHandler` ([#16852](https://github.com/getsentry/sentry-javascript/pull/16852))
+- feat(feedback): Return the eventId into the onSubmitSuccess callback ([#16835](https://github.com/getsentry/sentry-javascript/pull/16835))
+- feat(vercel-edge): Do not vendor in all OpenTelemetry dependencies ([#16841](https://github.com/getsentry/sentry-javascript/pull/16841))
+- fix(browser): Ensure standalone CLS and LCP spans have traceId of pageload span ([#16864](https://github.com/getsentry/sentry-javascript/pull/16864))
+- fix(nextjs): Use value injection loader on `instrumentation-client.ts|js` ([#16855](https://github.com/getsentry/sentry-javascript/pull/16855))
+- fix(sveltekit): Avoid capturing `redirect()` calls as errors in Cloudflare ([#16853](https://github.com/getsentry/sentry-javascript/pull/16853))
+- docs(nextjs): Update `deleteSourcemapsAfterUpload` jsdoc default value ([#16867](https://github.com/getsentry/sentry-javascript/pull/16867))
+
+Work in this release was contributed by @zachkirsch. Thank you for your contribution!
+
 ## 9.36.0
 
 ### Important Changes

dev-packages/browser-integration-tests/package.json

@@ -39,8 +39,9 @@
     "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
   },
   "dependencies": {
+    "@babel/core": "^7.27.7",
     "@babel/preset-typescript": "^7.16.7",
-    "@playwright/test": "~1.50.0",
+    "@playwright/test": "~1.53.2",
     "@sentry-internal/rrweb": "2.34.0",
     "@sentry/browser": "9.36.0",
     "@supabase/supabase-js": "2.49.3",

dev-packages/browser-integration-tests/suites/errors/fetch/init.js

@@ -4,10 +4,4 @@ window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  transportOptions: {
-    fetchOptions: {
-      // See: https://github.com/microsoft/playwright/issues/34497
-      keepalive: false,
-    },
-  },
 });

dev-packages/browser-integration-tests/suites/stacktraces/init.js

@@ -4,10 +4,4 @@ window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  transportOptions: {
-    fetchOptions: {
-      // See: https://github.com/microsoft/playwright/issues/34497
-      keepalive: false,
-    },
-  },
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/http-timings/init.js

@@ -13,10 +13,4 @@ Sentry.init({
     }),
   ],
   tracesSampleRate: 1,
-  transportOptions: {
-    fetchOptions: {
-      // See: https://github.com/microsoft/playwright/issues/34497
-      keepalive: false,
-    },
-  },
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/init.js

@@ -14,10 +14,4 @@ Sentry.init({
     }),
   ],
   tracesSampleRate: 1,
-  transportOptions: {
-    fetchOptions: {
-      // See: https://github.com/microsoft/playwright/issues/34497
-      keepalive: false,
-    },
-  },
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/init.js

@@ -10,7 +10,7 @@ Sentry.init({
       consistentTraceSampling: true,
     }),
   ],
-  tracePropagationTargets: ['someurl.com'],
+  tracePropagationTargets: ['sentry-test-external.io'],
   tracesSampler: ctx => {
     if (ctx.attributes && ctx.attributes['sentry.origin'] === 'auto.pageload.browser') {
       return 1;

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/subject.js

@@ -11,7 +11,7 @@ btn1.addEventListener('click', () => {
 btn2.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
     Sentry.startSpan({ name: 'custom root span 2', op: 'custom' }, async () => {
-      await fetch('https://someUrl.com');
+      await fetch('http://sentry-test-external.io');
     });
   });
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/test.ts

@@ -111,7 +111,7 @@ sentryTest.describe('When `consistentTraceSampling` is `true`', () => {
 
     await sentryTest.step('Make fetch request', async () => {
       const fetchTracePromise = waitForTransactionRequest(page, evt => evt.contexts?.trace?.op === 'custom');
-      const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'https://someUrl.com');
+      const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'http://sentry-test-external.io');
 
       await page.locator('#btn2').click();
 

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/init.js

@@ -10,7 +10,7 @@ Sentry.init({
       consistentTraceSampling: true,
     }),
   ],
-  tracePropagationTargets: ['someurl.com'],
+  tracePropagationTargets: ['sentry-test-external.io'],
   tracesSampleRate: 1,
   debug: true,
   sendClientReports: true,

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/subject.js

@@ -11,7 +11,7 @@ btn1.addEventListener('click', () => {
 btn2.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
     Sentry.startSpan({ name: 'custom root span 2', op: 'custom' }, async () => {
-      await fetch('https://someUrl.com');
+      await fetch('http://sentry-test-external.io');
     });
   });
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/test.ts

@@ -50,7 +50,7 @@ sentryTest.describe('When `consistentTraceSampling` is `true` and page contains
       });
 
       await sentryTest.step('Make fetch request', async () => {
-        const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'https://someUrl.com');
+        const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'http://sentry-test-external.io');
 
         await page.locator('#btn2').click();
         const { baggage, sentryTrace } = await tracingHeadersPromise;

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-precedence/init.js

@@ -10,7 +10,7 @@ Sentry.init({
       consistentTraceSampling: true,
     }),
   ],
-  tracePropagationTargets: ['someurl.com'],
+  tracePropagationTargets: ['sentry-test-external.io'],
   tracesSampler: ({ inheritOrSampleWith }) => {
     return inheritOrSampleWith(0);
   },

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-precedence/subject.js

@@ -11,7 +11,7 @@ btn1?.addEventListener('click', () => {
 btn2?.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
     Sentry.startSpan({ name: 'custom root span 2', op: 'custom' }, async () => {
-      await fetch('https://someUrl.com');
+      await fetch('http://sentry-test-external.io');
     });
   });
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-precedence/test.ts

@@ -25,6 +25,9 @@ sentryTest.describe('When `consistentTraceSampling` is `true` and page contains
         sentryTest.skip();
       }
 
+
+
+
       const url = await getLocalTestUrl({ testDir: __dirname });
 
       const clientReportPromise = waitForClientReportRequest(page);
@@ -34,7 +37,7 @@ sentryTest.describe('When `consistentTraceSampling` is `true` and page contains
       });
 
       await sentryTest.step('Make fetch request', async () => {
-        const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'https://someUrl.com');
+        const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'http://sentry-test-external.io');
 
         await page.locator('#btn2').click();
 

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta/init.js

@@ -10,7 +10,7 @@ Sentry.init({
       consistentTraceSampling: true,
     }),
   ],
-  tracePropagationTargets: ['someurl.com'],
+  tracePropagationTargets: ['sentry-test-external.io'],
   // only take into account sampling from meta tag; otherwise sample negatively
   tracesSampleRate: 0,
   debug: true,

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta/subject.js

@@ -11,7 +11,7 @@ btn1.addEventListener('click', () => {
 btn2.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
     Sentry.startSpan({ name: 'custom root span 2', op: 'custom' }, async () => {
-      await fetch('https://someUrl.com');
+      await fetch('http://sentry-test-external.io');
     });
   });
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta/test.ts

@@ -131,7 +131,7 @@ sentryTest.describe('When `consistentTraceSampling` is `true` and page contains
 
       await sentryTest.step('Make fetch request', async () => {
         const fetchTracePromise = waitForTransactionRequest(page, evt => evt.contexts?.trace?.op === 'custom');
-        const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'https://someUrl.com');
+        const tracingHeadersPromise = waitForTracingHeadersOnUrl(page, 'http://sentry-test-external.io');
 
         await page.locator('#btn2').click();
 

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/tracesSampler-precedence/init.js

@@ -11,7 +11,7 @@ Sentry.init({
       enableInp: false,
     }),
   ],
-  tracePropagationTargets: ['someurl.com'],
+  tracePropagationTargets: ['sentry-test-external.io'],
   tracesSampler: ctx => {
     if (ctx.attributes && ctx.attributes['sentry.origin'] === 'auto.pageload.browser') {
       return 1;

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/tracesSampler-precedence/subject.js

@@ -11,7 +11,7 @@ btn1.addEventListener('click', () => {
 btn2.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
     Sentry.startSpan({ name: 'custom root span 2', op: 'custom' }, async () => {
-      await fetch('https://someUrl.com');
+      await fetch('http://sentry-test-external.io');
     });
   });
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/negatively-sampled/init.js

@@ -4,7 +4,8 @@ window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: [Sentry.browserTracingIntegration()],
+  // We want to ignore redirects for this test
+  integrations: [Sentry.browserTracingIntegration({ detectRedirects: false })],
   tracesSampler: ctx => {
     if (ctx.attributes['sentry.origin'] === 'auto.pageload.browser') {
       return 0;

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-aborting-pageload/init.js

@@ -4,9 +4,12 @@ window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: [Sentry.browserTracingIntegration()],
+  integrations: [Sentry.browserTracingIntegration({ idleTimeout: 2000 })],
   tracesSampleRate: 1,
 });
 
-// Immediately navigate to a new page to abort the pageload
-window.history.pushState({}, '', '/sub-page');
+// Navigate to a new page to abort the pageload
+// We have to wait >300ms to avoid the redirect handling
+setTimeout(() => {
+  window.history.pushState({}, '', '/sub-page');
+}, 500);

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click-early/init.js

@@ -0,0 +1,23 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  integrations: [Sentry.browserTracingIntegration()],
+  tracesSampleRate: 1,
+  debug: true,
+});
+
+document.getElementById('btn1').addEventListener('click', () => {
+  // Trigger navigation later than click, so the last click is more than 300ms ago
+  setTimeout(() => {
+    window.history.pushState({}, '', '/sub-page');
+
+    // then trigger redirect inside of this navigation, which should be detected as a redirect
+    // because the last click was more than 300ms ago
+    setTimeout(() => {
+      window.history.pushState({}, '', '/sub-page-redirect');
+    }, 100);
+  }, 400);
+});

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click-early/template.html

@@ -0,0 +1,7 @@
+<!doctype html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <button id="btn1">Trigger navigation</button>
+</html>

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click-early/test.ts

@@ -0,0 +1,41 @@
+import { expect } from '@playwright/test';
+import { sentryTest } from '../../../../../utils/fixtures';
+import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';
+
+sentryTest(
+  'should create a navigation.redirect span if a click happened more than 300ms before navigation',
+  async ({ getLocalTestUrl, page }) => {
+    if (shouldSkipTracingTest()) {
+      sentryTest.skip();
+    }
+
+    const url = await getLocalTestUrl({ testDir: __dirname });
+
+    const pageloadRequestPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');
+    const navigationRequestPromise = waitForTransactionRequest(
+      page,
+      event => event.contexts?.trace?.op === 'navigation',
+    );
+
+    await page.goto(url);
+
+    await pageloadRequestPromise;
+
+    // Now trigger navigation, and then a redirect in the navigation, with
+    await page.click('#btn1');
+
+    const navigationRequest = envelopeRequestParser(await navigationRequestPromise);
+
+    expect(navigationRequest.contexts?.trace?.op).toBe('navigation');
+    expect(navigationRequest.transaction).toEqual('/sub-page');
+
+    const spans = navigationRequest.spans || [];
+
+    expect(spans).toContainEqual(
+      expect.objectContaining({
+        op: 'navigation.redirect',
+        description: '/sub-page-redirect',
+      }),
+    );
+  },
+);

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click/init.js

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  integrations: [Sentry.browserTracingIntegration()],
+  tracesSampleRate: 1,
+  debug: true,
+});

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click/subject.js

@@ -0,0 +1,7 @@
+document.getElementById('btn1').addEventListener('click', () => {
+  // trigger redirect immediately
+  window.history.pushState({}, '', '/sub-page');
+});
+
+// Now trigger click, which should trigger navigation
+document.getElementById('btn1').click();

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click/template.html

@@ -0,0 +1,7 @@
+<!doctype html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <button id="btn1" type="button">Trigger navigation</button>
+</html>

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click/test.ts

@@ -0,0 +1,34 @@
+import { expect } from '@playwright/test';
+import { sentryTest } from '../../../../../utils/fixtures';
+import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';
+
+sentryTest(
+  'should not create a navigation.redirect span if a click happened before navigation',
+  async ({ getLocalTestUrl, page }) => {
+    if (shouldSkipTracingTest()) {
+      sentryTest.skip();
+    }
+
+    const url = await getLocalTestUrl({ testDir: __dirname });
+
+    const pageloadRequestPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');
+    const navigationRequestPromise = waitForTransactionRequest(
+      page,
+      event => event.contexts?.trace?.op === 'navigation',
+    );
+
+    await page.goto(url);
+
+    const pageloadRequest = envelopeRequestParser(await pageloadRequestPromise);
+    // Ensure a navigation span is sent, too
+    await navigationRequestPromise;
+
+    const spans = pageloadRequest.spans || [];
+
+    expect(spans).not.toContainEqual(
+      expect.objectContaining({
+        op: 'navigation.redirect',
+      }),
+    );
+  },
+);