fix(browser): Ensure standalone CLS and LCP spans have traceId of pageload span #16864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on top of #16863
this PR fixes a bug in standalone web vital spans where, if they were sent because of a navigation, they would incorrectly be added to the
navigation
span's trace instead of the initialpageload
span's trace. This surfaced while dogfooding these spans on sentry and inspecting them in the EAP traceview.To fix this, I added a lifecycle hook in #16863 that triggers right before we start preparing the navigation span and hence, right before we recycle the propagation context to the new traceId. This PR now makes use of the new hook for CLS and LCP spans and it also makes the integration tests stricter to check for the correct trace ids.