Skip to content

fix(nextjs): Use value injection loader on instrumentation-client.ts|js #16855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Jul 9, 2025

Just stumbled on this while trying to inject some client values: We now recommend using an instrumentation-client file instead of sentry.client.config.js|ts but we never updated this loader to run on the newer file.

@chargome chargome self-assigned this Jul 9, 2025
@chargome chargome requested review from Lms24 and andreiborza July 9, 2025 10:42
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Do we know if this caused an issue previously?

@chargome
Copy link
Member Author

chargome commented Jul 9, 2025

Do we know if this caused an issue previously?

Thought of this but nothing that rings my bell

@chargome chargome merged commit ccb129b into develop Jul 9, 2025
168 checks passed
@chargome chargome deleted the cg-value-injection-instrumentation-client branch July 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants