Skip to content

test(node): Unflake feature flag test #16636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

test(node): Unflake feature flag test #16636

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
646417a
test(node): Unflake feature flag test
mydea Jun 18, 2025
e879b40
wait longer
mydea Jun 18, 2025
2ce27c9
better unflake
mydea Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions ...tegration-tests/suites/featureFlags/featureFlagsIntegration/onError/withScope/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
import type { Scope } from '@sentry/node';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

const flagsIntegration = Sentry.featureFlagsIntegration();

Sentry.init({
dsn: 'https://[email protected]/1337',
sampleRate: 1.0,
transport: loggingTransport,
integrations: [Sentry.featureFlagsIntegration()],
integrations: [flagsIntegration],
});

const flagsIntegration = Sentry.getClient()?.getIntegrationByName<Sentry.FeatureFlagsIntegration>('FeatureFlags');
flagsIntegration?.addFeatureFlag('shared', true);
async function run(): Promise<void> {
flagsIntegration.addFeatureFlag('shared', true);

Sentry.withScope((_scope: Scope) => {
flagsIntegration?.addFeatureFlag('forked', true);
flagsIntegration?.addFeatureFlag('shared', false);
Sentry.captureException(new Error('Error in forked scope'));
});
Sentry.withScope(() => {
flagsIntegration.addFeatureFlag('forked', true);
flagsIntegration.addFeatureFlag('shared', false);
Sentry.captureException(new Error('Error in forked scope'));
});

await Sentry.flush();

flagsIntegration.addFeatureFlag('main', true);

throw new Error('Error in main scope');
}

flagsIntegration?.addFeatureFlag('main', true);
throw new Error('Error in main scope');
// eslint-disable-next-line @typescript-eslint/no-floating-promises
run();
Loading