Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ export default [
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
route('server-loader', 'routes/performance/server-loader.tsx'),
route('server-action', 'routes/performance/server-action.tsx'),
]),
] satisfies RouteConfig;
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { Form } from 'react-router';
import type { Route } from './+types/server-action';

export async function action({ request }: Route.ActionArgs) {
let formData = await request.formData();
let name = formData.get('name');
await new Promise(resolve => setTimeout(resolve, 1000));
return {
greeting: `Hola ${name}`,
};
}

export default function Project({ actionData }: Route.ComponentProps) {
return (
<div>
<h1>Server action page</h1>
<Form method="post">
<input type="text" name="name" />
<button type="submit">Submit</button>
</Form>
{actionData ? <p>{actionData.greeting}</p> : null}
</div>
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -132,4 +132,31 @@ test.describe('servery - performance', () => {
origin: 'auto.http.react-router',
});
});

test('should automatically instrument server action', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === 'POST /performance/server-action.data';
});

await page.goto(`/performance/server-action`);
await page.getByRole('button', { name: 'Submit' }).click(); // this will trigger a .data request

const transaction = await txPromise;

expect(transaction?.spans?.[transaction.spans?.length - 1]).toMatchObject({
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.http.react-router',
'sentry.op': 'function.react-router.action',
},
description: 'Executing Server Action',
parent_span_id: expect.any(String),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'function.react-router.action',
origin: 'auto.http.react-router',
});
});
});
2 changes: 1 addition & 1 deletion packages/react-router/src/server/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function init(options: NodeOptions): NodeClient | undefined {
const overwrite = event.contexts?.trace?.data?.[SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITE];
if (
event.type === 'transaction' &&
event.transaction === 'GET *' &&
(event.transaction === 'GET *' || event.transaction === 'POST *') &&
event.contexts?.trace?.data?.[ATTR_HTTP_ROUTE] === '*' &&
overwrite
) {
Expand Down
Loading