Skip to content

Conversation

@HazAT
Copy link
Member

@HazAT HazAT commented Sep 30, 2018

No description provided.

@HazAT HazAT self-assigned this Sep 30, 2018
@HazAT HazAT requested a review from kamilogorek as a code owner September 30, 2018 14:39
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Sep 30, 2018

Fails
🚫

Danger failed to run dangerfile.ts.

Warnings
⚠️

Please add a changelog entry for your changes.

Messages
📖

✅ TSLint passed

📖

@sentry/browser gzip'ed minified size: 21.9814 kB

Error TypeError

Cannot read property 'toFixed' of undefined
TypeError: Cannot read property 'toFixed' of undefined
    at Object.<anonymous> (/home/travis/build/getsentry/sentry-javascript/node_modules/danger-plugin-codecov/dist/index.js:48:47)
    at Generator.next (<anonymous>)
    at fulfilled (/home/travis/build/getsentry/sentry-javascript/node_modules/danger-plugin-codecov/dist/index.js:4:58)
    at <anonymous>

Dangerfile

43|       });
44|     } else {
45|       message('✅ TSLint passed');
46|     }
47|   });
-------------------------------------------------^
48| 
49|   const hasChangelog = danger.git.modified_files.indexOf('CHANGELOG.md') !== -1;
50|   const isTrivial = (danger.github.pr.body + danger.github.pr.title).includes('#trivial');
51| 

Generated by 🚫 dangerJS

@HazAT
Copy link
Member Author

HazAT commented Oct 1, 2018

I will merge this as soon as I debugged my plugin in the evening ^^

@HazAT HazAT closed this Nov 15, 2018
@HazAT HazAT deleted the feature/add-danger-codecov branch November 15, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants