feat(node): Skip patching when breadcrumbs are disabled #15733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, yes, but this will not be true anymore wenn this: #15735 is merged. but we can still check for multiple conditions then and avoid adding the instrumentation when we know it would do nothing! |
|
I think this can be closed now as we've refactored this quite a bit in the meanwhile, not using wrapping anymore but diagnostics channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understood this correctly we can save some work when breadcrumbs are disabled as the only outcome here is
addRequestBreadcrumb(request, response);anywayref #15725