Skip to content

feat(node): Replace withScope with getCurrentScope in http instrumentation #15731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(node): Replace withScope with getCurrentScope in http instrumentation #15731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/node/src/integrations/http/SentryHttpInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ import {
generateSpanId,
getBreadcrumbLogLevelFromHttpStatusCode,
getClient,
getCurrentScope,
getIsolationScope,
getSanitizedUrlString,
httpRequestToRequestData,
logger,
parseUrl,
stripUrlQueryAndFragment,
withIsolationScope,
withScope,
} from '@sentry/core';
import { DEBUG_BUILD } from '../../debug-build';
import { getRequestUrl } from '../../utils/getRequestUrl';
Expand Down Expand Up @@ -185,11 +185,9 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
}

return withIsolationScope(isolationScope, () => {
return withScope(scope => {
// Set a new propagationSpanId for this request
scope.getPropagationContext().propagationSpanId = generateSpanId();
return original.apply(this, [event, ...args]);
});
// Set a new propagationSpanId for this request
getCurrentScope().getPropagationContext().propagationSpanId = generateSpanId();
return original.apply(this, [event, ...args]);
});
};
};
Expand Down
Loading