fix: Use correct native node types #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
requested changes
Sep 17, 2018
packages/node/src/transports/base.ts
Outdated
|
|
||
| /** The Agent used for corresponding transport */ | ||
| protected client: http.Agent | https.Agent | undefined; | ||
| protected client: http.Agent | https.Agent | https.Agent | undefined; |
There was a problem hiding this comment.
There is one https.Agent too much, right?
kamilogorek
force-pushed
the
node-types
branch
from
38c9c1a to
5ac4dd9
Compare
HazAT
approved these changes
Sep 17, 2018
|
❤️ |
SimonSchick
reviewed
Sep 17, 2018
| /** JSDoc */ | ||
| export function requestHandler(): (req: Request, res: Response, next: () => void) => void { | ||
| return function sentryRequestMiddleware(req: Request, _res: Response, next: () => void): void { | ||
| export function requestHandler(): (req: http.ClientRequest, res: http.ServerResponse, next: () => void) => void { |
There was a problem hiding this comment.
As a note, I don't exactly know what kind of style for imports you are following but you can import just import ClientRequest and ServerResponse to reduce verbosity or are you doing this to avoid type collissions in your builds?
|
@SimonSchick we do have some types that may interfere, therefore I sometimes used different syntax. It's always better to unify though, so all external and native modules are now using prefixed syntax. Thanks for pointing that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1530