Skip to content

feat: Add defaultIntegrations option #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2018
Merged

feat: Add defaultIntegrations option #1532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab1789
feat: Add defaultIntegrations option
HazAT Sep 14, 2018
b728463
fix: Import order
HazAT Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/baseclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import {
Severity,
Status,
} from '@sentry/types';
import { getGlobalObject, uuid4 } from '@sentry/utils/misc';
import { forget } from '@sentry/utils/async';
import { getGlobalObject, uuid4 } from '@sentry/utils/misc';
import { truncate } from '@sentry/utils/string';
import { BackendClass } from './basebackend';
import { Dsn } from './dsn';
Expand Down
5 changes: 5 additions & 0 deletions packages/core/src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ export interface Options {
*/
dsn?: string;

/**
* If this is set to false, default integrations will not be added.
*/
defaultIntegrations?: boolean;

/**
* List of integrations that should be installed after SDK was initialized.
* Accepts either a list of integrations or a function that receives
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function initAndBind<F extends Client, O extends Options>(
// there needs to be a client on the hub already.
getCurrentHub().bindClient(client);

let integrations = [...defaultIntegrations];
let integrations = options.defaultIntegrations === false ? [] : [...defaultIntegrations];
if (Array.isArray(options.integrations)) {
const providedIntegrationsNames = options.integrations.map(i => i.name);
integrations = [
Expand Down
10 changes: 10 additions & 0 deletions packages/core/test/lib/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ describe('SDK', () => {
expect(DEFAULT_INTEGRATIONS[1].handler.mock.calls.length).toBe(1);
});

test('not installs default integrations', () => {
const DEFAULT_INTEGRATIONS: Integration[] = [
new MockIntegration('MockIntegration 1'),
new MockIntegration('MockIntegration 2'),
];
initAndBind(TestClient, { defaultIntegrations: false }, DEFAULT_INTEGRATIONS);
expect(DEFAULT_INTEGRATIONS[0].handler.mock.calls.length).toBe(0);
expect(DEFAULT_INTEGRATIONS[1].handler.mock.calls.length).toBe(0);
});

test('installs integrations provided through options', () => {
const integrations: Integration[] = [
new MockIntegration('MockIntegration 1'),
Expand Down