feat(core): Deprecate APIs around RequestSessions
#14566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
force-pushed
the
lforst-request-session-deprecations
branch
from
a7098d5 to
3442ff7
Compare
mydea
approved these changes
Dec 5, 2024
|
To elaborate, the plan is for the httpIntegration to create it's own sessions for each incoming request, and also mark sessions within the request context as faulty when an error is captured. This can be done with the session being kept in some AsyncLocalStorage or similar. Request Sessions are completely owned by the http integration and should not be interfaced with by the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14550
As part of improving and simplifying the Sessions API we want to move all functionality related to sessions into integrations which includes hiding the implementation details of SessionAggregates behind the httpIntegration.
This PR deprecates all APIs that are necessary to make that move.