-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref: Set normalizedRequest instead of request in various places
#14305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
size-limit report 📦
|
ff41cbd to
87316c9
Compare
| request: { | ||
| cookies: {}, | ||
| headers: expect.any(Object), | ||
| url: expect.any(String), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was actually wrong - previously, when we only had headers on the request, we'd incorrectly infer the url from the origin header. However, since we had nothing else to go on, that would be wrong - because a) it would always use http://, and be the path would be missing, so you'd always get e.g. http://localhost:3000 or http://sentry.io. This change actually "fixes" this by simply not having a URL anymore.
normalizedRequest instead of request various placesnormalizedRequest instead of request in various places
87316c9 to
2eec3c4
Compare
The request data integration prefers this over
request, we want to get rid ofrequestin v9.Updates the following:
Part of #14298