fix(module): keep version for node ESM package #13922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module federation needs package version for comparison fixes getsentry#12433
|
Thank you for opening this, this seems fine to me and I think it makes sense. @timfish since you initially wrote this ESM build code, any thoughts or concerns from your side on this? |
timfish
approved these changes
Oct 10, 2024
mydea
approved these changes
Oct 11, 2024
mydea
added a commit
that referenced
this pull request
Oct 11, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13922 Co-authored-by: mydea <[email protected]>
billyvg
pushed a commit
that referenced
this pull request
Oct 17, 2024
Module federation needs package version for comparison fixes #12433
billyvg
pushed a commit
that referenced
this pull request
Oct 17, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13922 Co-authored-by: mydea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module federation needs package version for comparison
fixes #12433