test(e2e): Add Astro 4 E2E test app #13375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifferences in release
Lms24
commented
Aug 14, 2024
Comment on lines
+22
to
+25
| trace: { | ||
| span_id: '', //TODO: This is a bug! We should expect.stringMatching(/[a-f0-9]{16}/) instead of '' | ||
| trace_id: expect.stringMatching(/[a-f0-9]{32}/), | ||
| }, |
There was a problem hiding this comment.
This is likely an SDK bug that surfaced through this test. I'll look into this but don't want to further block adding the tests. When we fix this, the test will fail and we'll adjust it anyway.
lforst
approved these changes
Aug 14, 2024
Zen-cronic
pushed a commit
to Zen-cronic/sentry-javascript
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we have no e2e tests yet for Astro and I fixed a couple of bugs recently, I figured it'd be great to quickly (=== spend hours fighting with pnpm) build one.
Discovered another weirdness along the way with a missing parent span id (see review comment) but we can fix this in a follow-up PR.